search

yozoon / gnome-shell-extension-blyr

Apply a Blur Effect to GNOME Shell UI elements
https://extensions.gnome.org/extension/1251/blyr/
GNU General Public License v2.0
222 stars 18 forks source link

Error Gnome 3.38 #58

Open rebdeg opened 4 years ago

rebdeg commented 4 years ago

Can't install this extension under gnome 3.37.92 (3.38), gives an error.

dayfuaim commented 4 years ago

I confirm this.

It's "No JS module 'tweener' found in search path", to be more precise.

yozoon commented 4 years ago

Thanks for reporting this bug - I will look into it as soon as I have a GNOME 3.38 installation available for testing.

xerz-one commented 4 years ago

Have you debugged the issue? GNOME OS is available if your distro is still stuck on 3.36

ghost commented 4 years ago

There's also Ubuntu 20.10 beta and Fedora 33 beta I believe, dying for this to be fixed, the same error has broke a few extensions I use actually

MichalLebeda commented 4 years ago

Have you debugged the issue? GNOME OS is available if your distro is still stuck on 3.36

It is evident that Tweener has been removed see link

yozoon commented 4 years ago

I'm on Arch, which already updated GNOME to version 3.38. Yes the removal of Tweener is one problem, but the second complication is that GNOME also changed the way background content is represented in the MetaBackground actor... fixing this without causing problems for older versions will take some time

aeveris commented 4 years ago

Tweener is still available, but its import path has changed to imports.tweener.tweener

MichalLebeda commented 4 years ago

I'm on Arch, which already updated GNOME to version 3.38. Yes the removal of Tweener is one problem, but the second complication is that GNOME also changed the way background content is represented in the MetaBackground actor... fixing this without causing problems for older versions will take some time

tried to fix that in my pull req, but i thought that versioning is managed by extensions gnome webpage. So you can ignore it as it doesn't handle shell versions (my fault)

MichalLebeda commented 4 years ago

Can't we just use older version for 3.36 and newer fixed version for 3.38+?

ghost commented 4 years ago

I'm just a user who reports bugs I find but I'd personally be fine with the above ^ assuming the devs would want to do it. Maybe a branch for the people willing to test and help out or something?

MichalLebeda commented 4 years ago

I'm just a user who reports bugs I find but I'd personally be fine with the above ^ assuming the devs would want to do it. Maybe a branch for the people willing to test and help out or something?

my fork works on 3.38 and it was easy to fix. The problem is, that it blinks with blackscreen when closing overview now, IDK why + no backward compatibility

yozoon commented 4 years ago

You can now test the extension on branch 338. It generally works now by checking the shell version and doing the appropriate action for that version (way to many if statements for my taste...). But sometimes I still get some some weird runtime behaviour like panel blur appearing and disappearing spontaneousely. For some reason the panel background opacity gets blurred sometimes as well, leading to a washed out blur effect... Maybe someone can pin down the exact cause of those problems. I haven't yet been able to find anything in the logs that could point me towards a solution.

ghost commented 4 years ago

I'll get to testing and let you know if I find anything reliable or useful, as always big thanks yozoon!

ghost commented 4 years ago

Edit: It's running pretty well on my end, haven't seen any panel weirdness yet but I have found three issues, where's the best place to report the issue?

Alexmitter commented 4 years ago

Isn't tweener now just imports.tweener.tweener; instead of imports.ui.tweener; ?

Like Panel OSD extension does https://gitlab.com/jenslody/gnome-shell-extension-panel-osd/-/merge_requests/30/diffs

maxjf1 commented 4 years ago

Its possible to use something like this to keep it compatible?

const Tweener = imports.tweener ? imports.tweener.tweener :  imports.ui.tweener;
Hexcz commented 3 years ago

Changed Tweener const as seen on @Alexmitter post, and installed clutter, didnt worked...

Hexcz commented 3 years ago

You can now test the extension on branch 338. It generally works now by checking the shell version and doing the appropriate action for that version (way to many if statements for my taste...). But sometimes I still get some some weird runtime behaviour like panel blur appearing and disappearing spontaneousely. For some reason the panel background opacity gets blurred sometimes as well, leading to a washed out blur effect... Maybe someone can pin down the exact cause of those problems. I haven't yet been able to find anything in the logs that could point me towards a solution.

Apparently the changes on this branch worked for me. No issues found so far. Thanks!

henrik-wittenberg commented 3 years ago

Does not work for me on manjaro gnome 3.38.2 (lg shows "No JS module 'tweener' found in search path").

Hexcz commented 3 years ago

Does not work for me on manjaro gnome 3.38.2 (lg shows "No JS module 'tweener' found in search path").

Try using the 338 branch instead of master. It should work.

ghost commented 3 years ago

I just wanted to come back and say, I've been using the 338 branch since just before Ubuntu 20.10 released in hopes of being useful and reporting bugs but besides the one already reported about the folders in dash, I haven't run into any. It's working smoothly for me.