Closed ct16k closed 8 years ago
Thanks for this! Will take a look probably next Monday.
Update?
Totally lost track of this. Sorry :(. Will look in the morning.
np, was just a curious ping because im willing to try out the plugin but got no rush.
Just read some of the code myself and maybe @ct16k can tell: You added infernalis in the ceph make file, is there any reason for this?
I changed the version from hammer to infernalis only because that is the version of Ceph I tested the plugin against and I wanted to match the version of the plugin's dependencies with that of the cluster's services.
Unrelated, the commit I just pushed was to fix a conflict between the base branch and my fork. Serves me right for bundling multiple changes into a single PR.
It resolve all problems. Why still not merge?
Hello,
This is my quick attempt at fixing #21 #23. I've done some quick tests on CentOS 7.2 with docker 1.10.2 and ceph 9.2.0 and it seems to work for me.
The Get call is just a copy-paste of Path, with a slightly different output format, as per docs, while the List call is a simple implementation, with no error checking, as apparently make and append can't fail? (I'm a Go noob, this is actually my first time using it.)
I've also included some misc changes that seemed small/harmless enough to not warrant a different PR: