search

yp-engineering / rbd-docker-plugin

Ceph RBD docker volume driver plugin.
MIT License
102 stars 70 forks source link

Unmount rbd when remove containers #40

Closed aisensiy closed 8 years ago

aisensiy commented 8 years ago

rbd-docker-plugin is necessary when using distributed docker cluster. It is not acceptable to remove the data volume during container rescheduled from one machine to another.

And the comment near Remove function is talking about the behavior in mesos/marathon env. I think that unmount the rbd is the best way to handle this right now. But I still comment (not remove) the original code right now.

porcupie commented 8 years ago

@aisensiy Thanks for the pull request, however I don't think I can accept it. In another fork, soon to be merged with this one, I have also provided another mode of operation for the plugin to just ignore the remove operation. Also, in our usage we have used the actual Ceph RBD remove functionality and so I will not remove that for others who also might make use of it.

I will try to merge up that other fork (porcupie/rbd-docker-plugin) as soon as I can, to provide this fork with the same feature of just ignoring the remove operation and don't perform any Ceph actions for the docker volume remove.