search

ypaaf / you-play-as-a-frog

https://ypaaf.pages.dev/
0 stars 0 forks source link

Dead centipedes cause a crash when loading save #35

Open qwertyuiopwm opened 4 months ago

qwertyuiopwm commented 4 months ago

I can't figure this out

Oshawhaat commented 4 months ago

Is it just when you save while the centipede is dying?

qwertyuiopwm commented 4 months ago

No, it's when you kill a baby centipede over in the cave, and then save + load. A fix I can think of would be to replace all occurrences of the baby centipede with something like what you did for the big centipede in the forest

On Wed, May 22, 2024 at 9:59 AM Oshawhat @.***> wrote:

Is it just when you save while the centipede is dying?

— Reply to this email directly, view it on GitHub https://github.com/ypaaf/you-play-as-a-frog/issues/35#issuecomment-2125019462, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD7T6O23TPFLC26RZSJH2SLZDSXD5AVCNFSM6AAAAABICNOJRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVGAYTSNBWGI . You are receiving this because you authored the thread.Message ID: @.***>

Oshawhaat commented 4 months ago

Do you ignore previously freed instances when saving? the error I'm getting looks like a freed instance was loaded into the scene or something

qwertyuiopwm commented 4 months ago

It should be

On Wed, May 22, 2024 at 10:08 AM Oshawhat @.***> wrote:

Do you ignore previously freed instances when saving? the error I'm getting looks like a freed instance was loaded into the scene or something

— Reply to this email directly, view it on GitHub https://github.com/ypaaf/you-play-as-a-frog/issues/35#issuecomment-2125041980, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD7T6O5XQK3HZ53FZXIHXWLZDSYHLAVCNFSM6AAAAABICNOJRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVGA2DCOJYGA . You are receiving this because you authored the thread.Message ID: @.***>

Oshawhaat commented 4 months ago

I have a really ugly fix, but it works I just added some check in ready and process to kill the segment if the next one is invalid

Image

Oshawhaat commented 4 months ago

Should I push this fix?

qwertyuiopwm commented 4 months ago

If it works, it works. We need the game to be released.

On Wed, May 22, 2024 at 10:16 AM Oshawhat @.***> wrote:

Should I push this fix?

— Reply to this email directly, view it on GitHub https://github.com/ypaaf/you-play-as-a-frog/issues/35#issuecomment-2125059827, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD7T6O3G2J7NP2E2FH6QAALZDSZDLAVCNFSM6AAAAABICNOJRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVGA2TSOBSG4 . You are receiving this because you authored the thread.Message ID: @.***>