search

ypcrts / fqdn

RFC-compliant FQDN validation and manipulation for Python.
http://fqdn.readthedocs.io/
Mozilla Public License 2.0
30 stars 11 forks source link

equality must be case insensitive RFC4343 s. 3 #10

Closed ypcrts closed 4 years ago

ypcrts commented 4 years ago

RFC4343 s. 3

   According to the original DNS design decision, comparisons on name
   lookup for DNS queries should be case insensitive [STD13].  That is
   to say, a lookup string octet with a value in the inclusive range
   from 0x41 to 0x5A, the uppercase ASCII letters, MUST match the
   identical value and also match the corresponding value in the
   inclusive range from 0x61 to 0x7A, the lowercase ASCII letters.

@wakemaster39 The equality implementation did not account for case insensitivity, only absolute vs relative. This adds that. Would you have any input?

wakemaster39 commented 4 years ago

Yep should of been lower cased, all my stuff I lowercase on input so I completely didn't think about it.

ypcrts commented 4 years ago

Thanks @wakemaster39