search

ypcrts / fqdn

RFC-compliant FQDN validation and manipulation for Python.
http://fqdn.readthedocs.io/
Mozilla Public License 2.0
30 stars 11 forks source link

Make lib Python 2.7-compatible #2

Closed gdubicki closed 7 years ago

gdubicki commented 7 years ago

Hey,

Thanks for a nice lib! I guess that you prefer Python 3 than 2 - same as me, btw - but I would be happy to be able to use it for a legacy Python 2 project. And also as this lib is so small keeping Python 2-compatible code won't be very painful.

So can you please consider merging this?

PS I am not very happy with solution I propose to run some tests on Python 3 only. Feel free to recommend a better one, I will fix it then.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 0af91b56351bbce9bb36d638391b88a56c43972a on gdubicki:python27 into d3479bf07cf7872b4cfffe31b7e56ef1510c8079 on guyhughes:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 2da1f1cb72115de609ee59630a9c1b9f23cbfc4c on gdubicki:python27 into d3479bf07cf7872b4cfffe31b7e56ef1510c8079 on guyhughes:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-38.0%) to 62.018% when pulling 2da1f1cb72115de609ee59630a9c1b9f23cbfc4c on gdubicki:python27 into d3479bf07cf7872b4cfffe31b7e56ef1510c8079 on guyhughes:develop.

guyhughes commented 7 years ago

Thanks for this!