search

ypcrts / fqdn

RFC-compliant FQDN validation and manipulation for Python.
http://fqdn.readthedocs.io/
Mozilla Public License 2.0
30 stars 11 forks source link

Underscores #20

Closed ypcrts closed 4 years ago

ypcrts commented 4 years ago

15 merged with develop

resolves #14

supports underscores, optionally

wakemaster39 commented 4 years ago

This looks good to me, its weird allowing the domain name to have underscores in it even though the CA's block it but I suppose if chromium is allowing it, it makes sense. It also feels weird with an underscore leading a domain mostly because those are identifiers for other DNS entry types like DKIM but again if chromium allows it, it makes sense to do the same.

wakemaster39 commented 4 years ago

The only other thing I would say about a different change you made in develop is making flake8 part of pre-commit.

Love pre-commit and had it setup locally so I was making sure to black things, but I always hate flake8 as part of it. I personally allow code to be committed poorly, so that I can quickly expose PRs for review and the like, and then include it as part of the build before it can be merged.

Just a preference thing, but black 100% part of pre-commit.

wakemaster39 commented 4 years ago

Sorry another question about dev, why did install_requires=["cached-property>=1.3.0;python_version<'3.8'"], get rolled back to not having the version string?

ypcrts commented 4 years ago

yeah, i agree with you flake8 is pain. most of the formatting errors should be non-blocking; i should configure this correctly. i haven’t been a full-time dev in a few years now so i’m probably slightly out of date on exactly how to do this best.

black doesn’t do linting though. flake8 pointed out unused imports and use before assignment errors.

i’ll look into this deeper

Sent from ProtonMail Mobile

On Mon, Sep 14, 2020 at 16:22, wakemaster39 notifications@github.com wrote:

The only other thing I would say about a different change you made in develop is making flake8 part of pre-commit.

Love pre-commit and had it setup locally so I was making sure to black things, but I always hate flake8 as part of it. I personally allow code to be committed poorly, so that I can quickly expose PRs for review and the like, and then include it as part of the build before it can be merged.

Just a preference thing, but black 100% part of pre-commit.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.