ypcrts / fqdn

RFC-compliant FQDN validation and manipulation for Python.
http://fqdn.readthedocs.io/
Mozilla Public License 2.0
30 stars 11 forks source link

feat: added equality of FQDNs #7

Closed wakemaster39 closed 4 years ago

wakemaster39 commented 4 years ago

Resolves #6

wakemaster39 commented 4 years ago

Fixed up those issue, I am not use to unittest, meant to use equal.

the failure of python3.4 is something I am fighting in a lot of PRs across other libraries as well. I would make a couple suggestions like making this project locked by poetry so you can control the version being used during development or dropping python 3.4 support.

I also highly recommend pre-commit, had no idea this was locked by black till I came back and read the build failures.