fix: `gsettings` failed when GIO_EXTRA_MODULES env not set; `notify-send` failed when the message contains blank character

ypingcn / BingWallpaper

update your wallpaper using BingWallpaper - 将当天的必应美图设置为桌面背景(打包先运行 config.sh 脚本)

GNU General Public License v3.0

37 stars 13 forks source link

fix: `gsettings` failed when GIO_EXTRA_MODULES env not set; `notify-send` failed when the message contains blank character #14

Closed Danceiny closed 5 years ago

Danceiny commented 5 years ago

in case that the first param of send-notify contains blank character

ypingcn commented 5 years ago

呃为什么要加 GIO_EXTRA_MODULES 相关的代码，能稍微解释下吗？

还有，还要麻烦你在 dev 分支改，并用 http://www.ruanyifeng.com/blog/2016/01/commit_message_change_log.html 这里的格式或者参考历史提交写 commit log，这次 PR 暂时不合并。

Can you explain why add GIO_EXTRA_MODULES related code ?

Please commit code in dev branch for Pull request, and write commit log according to history commit or this article http://www.ruanyifeng.com/blog/2016/01/commit_message_change_log.html, I will not merge this pull request temporarily, thanks

Danceiny commented 5 years ago

@ypingcn 抱歉，改得比较草率，而且应该是两个pr。 GIO_EXTRA_MODULES的解释是，如果没有这个环境变量，执行gsettings命令时会报错：gsettings your settings will not be saved or shared with other applications.，我参考了https://stackoverflow.com/questions/44934641/glib-gio-message-using-the-memory-gsettings-backend-your-settings-will-not-b。

ypingcn commented 5 years ago

@Danceiny 那麻烦你在 dev 分支按格式改再 PR 一次吧，一点小要求，不好意思哈

ypingcn commented 5 years ago

@Danceiny 好像操作错了，提示 This branch has conflicts that must be resolved

你把你自己的那份删了，重新 fork ，切到 dev 分支，修改后 PR，你这样我的记录全乱了

一点强迫症，不好意思麻烦了。这次 PR 我关了。

Danceiny commented 5 years ago

没事没事，应该的