search

ypnos-web / cakephp-datatables

CakePHP3 Plugin for DataTables plug-in for jQuery
MIT License
27 stars 24 forks source link

Search for "0" - Zero value #77

Closed frent closed 4 years ago

frent commented 4 years ago

When searching for a number (zero) for localSearch, you don't get into the localsearch cause of empty check.

It can be fixed for also checking on the length according to the stackoverflow question: https://stackoverflow.com/questions/410002/fixing-the-php-empty-function

Line: 184 if (!empty($localSearch) || strlen($localSearch) != 0) {

ypnos-web commented 4 years ago

Did you miss this commit? https://github.com/ypnos-web/cakephp-datatables/commit/8e2f7d841535505c86d05be13cef392542f399c3 I might have to do a release for it.

frent commented 4 years ago

Sorry my mistake! I guess it didn't update.