yql / yql-tables

YQL is extensible using a table definition. This repository will hold community contributed definitions.
http://developer.yahoo.com/yql
724 stars 416 forks source link

Fix yahoo finance oquote table to reflect change in a div class #421

Closed doom99 closed 10 years ago

doom99 commented 10 years ago

During the week of 3/3/14 yahoo changed the finance quote pages such that this: class='yfi_rt_quote_summary_rt_top'

was changed to: class='yfi_rt_quote_summary_rt_top sigfig_promo_1'

it was necessary to reflect this change in oquote in order for it to return any results.

doom99 commented 10 years ago

@bishinew: AFAIK someone from the YQL group has to commit the change. First time I've done anything on Github but I followed instructions to make a pull request. You can use the change in the meantime if you can host the XML file yourself. Then your query is like:
USE "http://xxx.yyy.zzz/oquote.xml as oquote; SELECT ....... FROM oquote .........

And FWIW - if you are using this from an application, yahoo appears to have fubared (for android) the https connection to query.yahooapis.com by omitting the intermediary certificate authorithy that has happened only in the past few days but standard http connection still works

does this help?

bishinew commented 10 years ago

@doom99 Thanks.

Does anyone know how to commit the changes from doom99?

doom99 commented 10 years ago

To anyone waiting on this... I have no idea how/when datatables.org pulls in changes from github. As of 3/31 this change is not reflected.

bishinew commented 10 years ago

@pjdonnelly This change is still not in datatables.org. Do you know why? So the issue is not closed yet.

pjdonnelly commented 10 years ago

try now.

doom99 commented 10 years ago

@pjdonnelly Looks good, just tried it. Hopefully they leave the page structure alone for a whlie. Thanks

bishinew commented 10 years ago

@pjdonnelly & @doom99 Thanks Guys.

bishinew commented 10 years ago

Hi @pjdonnelly & @doom99

http://www.datatables.org/yahoo/finance/oquote/yahoo.finance.oquote.xml broke again. Can you guys help fixing it?

Thank you very much.