search

yql / yql-tables

YQL is extensible using a table definition. This repository will hold community contributed definitions.
http://developer.yahoo.com/yql
724 stars 416 forks source link

Updated yahoo.finance.keystatistics.xml #438

Open JayDeeNZ opened 10 years ago

JayDeeNZ commented 10 years ago

Work with changed xpath on Yahoo finance.

BobAleena commented 10 years ago

What is preventing this from being merged?

JayDeeNZ commented 10 years ago

I believe either a moderator or the owner of the original code needs to approve the pull request.

In the meantime you can still use this fix in the YQL console like so: use "https://raw.githubusercontent.com/yql/yql-tables/4404b415f2c5a2353966f7d054c238e29ef1a292/yahoo/finance/yahoo.finance.keystats.xml" as keystatistics; select * from keystatistics where symbol='MSFT';

BobAleena commented 10 years ago

not sure if I quite understand - I am trying to retrieve the info via a REST call -- currently I am using:

https://query.yahooapis.com/v1/public/yql?q=SELECT%20*%20FROM%20yahoo.finance.keystats%20WHERE%20symbol%3D'msft'&diagnostics=true&env=store%3A%2F%2Fdatatables.org%2Falltableswithkeys

are you saying to try placing the above
"https://raw.githubusercontent.com/yql/yql-tables/4404b415f2c5a2353966f7d054c238e29ef1a292/yahoo/finance/yahoo.finance.keystats.xml"

instead of yahoo.finance.keystats?

JayDeeNZ commented 10 years ago

You're almost right... It would be:

https://query.yahooapis.com/v1/public/yql?q=use%20%22https%3A%2F%2Fraw.githubusercontent.com%2Fyql%2Fyql-tables%2F4404b415f2c5a2353966f7d054c238e29ef1a292%2Fyahoo%2Ffinance%2Fyahoo.finance.keystats.xml%22%20as%20keystatistics%3B%20SELECT%20*%20FROM%20keystatistics%20WHERE%20symbol%3D'msft'%3B&diagnostics=true&env=store%3A%2F%2Fdatatables.org%2Falltableswithkeys

BobAleena commented 10 years ago

Exactly what I needed -- i'm unblocked on the keystats table error now. Thanks!

BobAleena commented 8 years ago

Looks like something has changed to break this again.