yql / yql-tables

YQL is extensible using a table definition. This repository will hold community contributed definitions.
http://developer.yahoo.com/yql
725 stars 416 forks source link

Yahoo finance.keystats is broken #447

Open altamont opened 9 years ago

altamont commented 9 years ago

yahoo.finance.keystats just returns the symbol. The old xpath is:

var keystatsquery = y.xpath( rawresult, "//table[@class='yfnc_datamodoutline1']/tr/td/table/tr" + "/td[@class='yfnc_tabledata1' or @class='yfnc_tablehead1']" );

I think it needs to be changed to: var keystatsquery = y.xpath( rawresult, "//table[@class='yfnc_datamodoutline1']/tbody/tr/td/table/tbody/tr" + "/td[@class='yfnc_tabledata1' or @class='yfnc_tablehead1']" );

it looks like there are tbody tags that are throwing it off. i haven't contributed to this project yet, and so i'm a little hesitant to make the change myself. can someone comment as to whether they agree with this?

TMcClain5 commented 9 years ago

I agree with you I believe that should fix the issue. The new tbody tag has to be what is throwing off all of the keystats queries.

berndsi commented 9 years ago

+1 I've made similar changes and more to another file (analystestimates) in PR 499.

tomasteicher commented 8 years ago

I tried to run YQL query to table "Yahoo finance.keystats" but it still returns only symbols. If I understnad correctly, I need to use Xpath, and not such YQL selects? I tried: SELECT * FROM yahoo.finance.keystats WHERE symbol in ("N4E.SI","BS6.SI", "YHOO") using env value: https://raw.githubusercontent.com/cynwoody/yql-tables/finance-1/tables.env

BobAleena commented 8 years ago

anyone get this working? I'm still getting back only symbols. Yahoo console keeps giving me a connect failure when i try it there too.

fho commented 7 years ago

Still broken would be awesome if something would get it fixed

florent522 commented 7 years ago

Any update?

BobAleena commented 7 years ago

Nope - still broken for me. I tried @johnmwilson82's fix from above, but not working for me still