yqrashawn / GokuRakuJoudo

config karabiner with ease
GNU General Public License v3.0
1.17k stars 120 forks source link

Any way to keep existing imported complex modifications #168

Open farzadmf opened 2 years ago

farzadmf commented 2 years ago

Hi,

I'm using goku to create my own modifications, but there are some that I've downloaded from Karabiner Website and import them into Karabiner.

When I run goku, however, it basically clears everything and adds my modifications. I was wondering if there's a way to keep existing ones and somehow "append" mine. Of course, they need to be replaced every time I run goku, so it may be complicated

It would be really nice if this is possible because it saves me the extra step(s) to re-add those bindings everytime I update goku config. (I could technically download them and port them to edn format, but then, I'd need to that in case they're updated)

Thank you

MuhammedZakir commented 2 years ago

Another advantage is that this makes it easy to gradually port existing JSON config to EDN. A simple solution is to move existing configs to a new profile and then asking goku to merge those into the default profile. If you are only using a single profile, that's enough. But for multiple profiles,, something like this would be nice:

{:profiles {:Default {:import-configs ["Old" "Imported"] ;; "Old" & "Imported" are profile names
                     ;; other keys
                     }}}
farzadmf commented 2 years ago

A simple solution is to move existing configs

@MuhammedZakir just to confirm, is the solution you're proposing doable now, or is it a suggestion of how it may work when it's implemented? 🙂

MuhammedZakir commented 2 years ago

A simple solution is to move existing configs

@MuhammedZakir just to confirm, is the solution you're proposing doable now, or is it a suggestion of how it may work when it's implemented? slightly_smiling_face

Latter, it was a suggestion / feature request.

shriharip commented 2 years ago

Facing the same issue. I would love to have a way to keep my imports rather than converting them and making changes again

januz commented 2 years ago

Also just starting to use Goku and was surprised that it wipes my existing complex modifications instead of appending to them. Any way to avoid having to add them again every time Goku is run? And/or is there a good converter tool for existing .json to .edn format? Thanks!