Changing :sim to :simlayer-threshold

[johnlindquist]

I see a lot of examples on github, etc using :sim in the config, but it doesn't change anything. :simlayer-threshold is what works.

:sim also appears in some of the tests, but I'm not confident enough in updating those 😬

[coveralls]

Pull Request Test Coverage Report for Build 305

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 87.284%

---

Totals
Change from base Build 304:	0.0%
Covered Lines:	1160
Relevant Lines:	1329

---

💛 - Coveralls

[nikitavoloboev]

but it doesn't change anything

It changes things for me.

[johnlindquist]

@nikitavoloboev For my karabiner.json file, simlayer-threshold updates where the threshold is defined in the rules (but not the parameters you're showing):

          "parameters" : {
            "basic.simultaneous_threshold_milliseconds" : 250
          },

As a test, set:

:sim 999

then search for 999 in your karabiner.json. Mine gives zero results.

then set:

:simlayer-threshold 999

and search for 999 again. Mine shows all the threshold values updated to 999.

[yqrashawn]

the :sim one is to set the default basic.simultaneous_threshold_milliseconds.

the :simlayer-threshold will override the above one in each rule in the parameters.basic.simultaneous_threshold_milliseconds

the second one is for setting the global basic.simultaneous_threshold_milliseconds before the profile feature (which added the :sim)

related issue comment https://github.com/yqrashawn/GokuRakuJoudo/issues/29#issuecomment-491476903

[eugenesvk]

Just got bitten by these testing simultaneous keys. Just to clarify: will this PR remove individual key parameters (currently hardcoded to 250 or overridden to another value with :simlayer-threshold 240) so that these keys will be able to read the global default values? I basically don't want any key combo to have this parameter unless it was explicitly specified in the key definition

Even the :simlayer-threshold option isn't great as it's confusing for the global settings in karabiner UI to be ignored, you have to remember that it's embedded in each key and can only be fixed via Goku