Closed ArminiusTux closed 1 month ago
I think those functions should be in some WinSock lib.
No idea why it's not linked against, https://github.com/yquake2/yquake2/blob/4b3545697ede842532dcace806859443db1b374b/CMakeLists.txt#L712C55-L712C61 explicitly lists ws2_32
, which should be the correct library according to https://learn.microsoft.com/en-us/windows/win32/winsock/creating-a-basic-winsock-application
Hello @DanielGibson ,
thank you for the fast reply.
I checked the situation with Visual Studio:
What do you think about making the server component optional (Cmake switch ON/OFF)?
Bingo?
ws2_32
was referenced twice in the main CMakeLists.txt
(until April):
line 687 for the client.exe
&
line 720 for the server.exe
until this commit by @Yamagi
Indeed, after changing line 751 to:
target_link_libraries(q2ded ${yquake2LinkerFlags} ${yquake2ZLibLinkerFlags} ws2_32 winmm)
Thank you @DanielGibson !
Cool! Does q2ded really need winmm (that's for multimedia stuff, I think?), or does ws2_32 (WinSock, networking stuff) suffice?
Does q2ded really need winmm (that's for multimedia stuff, I think?), or does ws2_32 (WinSock, networking stuff) suffice?
Properly not. It requires some investigation.
Greetings,
following your recent 8.40 release I tried to compile the new version with MSYS2 (Cmake+Clang+Ninja) on WinARM64:
failure on v8.40
``` $ git clone -b 'QUAKE2_8_40' https://github.com/yquake2/yquake2 Cloning into 'yquake2'... remote: Enumerating objects: 29195, done. remote: Counting objects: 100% (1729/1729), done. remote: Compressing objects: 100% (704/704), done. remote: Total 29195 (delta 1162), reused 1427 (delta 1017), pack-reused 27466 Receiving objects: 100% (29195/29195), 25.85 MiB | 19.35 MiB/s, done. Resolving deltas: 100% (20265/20265), done. Note: switching to '4e41dbf186d6d125b35ea338ec7472313071f0d5'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by switching back to a branch. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -c with the switch command. Example: git switch -cBack in March the situation was fine though:
success on v8.30+
``` $ git clone https://github.com/yquake2/yquake2 Cloning into 'yquake2'... remote: Enumerating objects: 28545, done. remote: Counting objects: 100% (1079/1079), done. remote: Compressing objects: 100% (439/439), done. remote: Total 28545 (delta 681), reused 943 (delta 635), pack-reused 27466 Receiving objects: 100% (28545/28545), 25.60 MiB | 13.57 MiB/s, done. Resolving deltas: 100% (19784/19784), done. $ cmake .. -DCMAKE_BUILD_TYPE=Release -- Building for: Ninja CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.5 will be removed from a future version of CMake. Update the VERSION argumentHoping for a quick (and easy) fix - bye.