search

yral-dapp / hot-or-not-web-leptos-ssr

Other
2 stars 9 forks source link

Message copy and behaviour change when ICP lead error #442

Open harshita-srivastava-yral opened 1 month ago

harshita-srivastava-yral commented 1 month ago

Whenever there is failure from ICP end and token doesn't get created:

  1. Remove the "Back to profile" CTA from the pop up
  2. Update the copy of the message on the Error pop up.

Subtext message : "Oops! There is some error from ICP's end. Please try again" CTA - Retry

Please refer to the attached screenshot for the current error Image Image

rupansh-sekar-yral commented 1 month ago

imo this is too early to implement and we should add logging/reporting around this before we remove the errors from UI. There are many errors that can happen and so far only a subset of them are due to IC. Lets properly analyse them and see where we can replace the message with something else. Right now these error messages are indispensible for our debugging

harshita-srivastava-yral commented 1 month ago

@rupansh-gob Aligned. Makes sense. I will create separate issue for error tracking...also we have event instrumented on FE around Creation failed, and it was really shocking to see that more creations are getting failed than successful...We will further add instrumentation to get an idea around the type of these errors.