search

yrnkrn / zapcc

zapcc is a caching C++ compiler based on clang, designed to perform faster compilations
Other
1.25k stars 61 forks source link

fix macOS ci #31

Closed ghost closed 4 years ago

ghost commented 5 years ago

sorry for the noise, I did not test my last PR properly, this PR is tested on private azure pipeline

they work on getting macOS 10.14 and ubuntu 18.04 images but they are not ready yet, I just thought they would have them

the produced zapcc binary passes first smoke test on my macOS machine

ubuntu gives

2018-12-07T16:12:44.3999115Z Checking out files: 100% (46220/46220), done.
2018-12-07T16:12:47.4561753Z CMake Deprecation Warning at CMakeLists.txt:14 (cmake_policy):
2018-12-07T16:12:47.4562885Z   The OLD behavior for policy CMP0051 will be removed from a future version
2018-12-07T16:12:47.4563252Z   of CMake.
2018-12-07T16:12:47.4563521Z 
2018-12-07T16:12:47.4564462Z   The cmake-policies(7) manual explains that the OLD behaviors of all
2018-12-07T16:12:47.4564607Z   policies are deprecated and that a policy should be set to OLD only under
2018-12-07T16:12:47.4564958Z   specific short-term circumstances.  Projects should be ported to the NEW
2018-12-07T16:12:47.4565266Z   behavior and not rely on setting a policy to OLD.
2018-12-07T16:12:47.4565464Z 
2018-12-07T16:12:47.4565492Z 
2018-12-07T17:35:03.7980886Z ##[section]Finishing: build on linux

not sure whats going on there, maybe a cmake version issue, I removed the linux part until someone can work this out

build time about 40min for macOS was surprisingly fast

would be great if you could create an azure account and provide macOS builds on the website 😃 🎉 maybe CI will also encourage others to try to merge/ edit some things

yrnkrn commented 5 years ago

It's great to hear zapcc starts working on MacOS! To check the build try ninja check-all.

You may safely ignore the The OLD behavior for policy CMP0051 message for now and keep the linux build. There were additional macOS changes in this pull request, could you pull request just these?