yrobink / SBCK

22 stars 9 forks source link

Easier installation in a conda environment #2

Closed aulemahal closed 2 years ago

aulemahal commented 2 years ago

Thanks for this awesome-looking package! I haven't gone far in exploring what it can do, but I had some issues when installing it into a conda environment.

"Eigen" is installable through conda (from conda-forge), but the include files get put in a non-standard folder (that's the point of an env), so pip can't find them when installing SBCK. I could have simply specified the path manually, but I realized that there was a more general way.

In setup.py, if we add os.path.dirname(sysconfig.get_paths()['include']), a vanilla pip call works! sysconfig is a built in module and this function returns the folder with the Python header files. Thus, logically, the parent folder is where we can find all include files installed through pip or conda.

I can suggest a PR soon.