search

yrutschle / sslh

Applicative Protocol Multiplexer (e.g. share SSH and HTTPS on the same port)
https://www.rutschle.net/tech/sslh/README.html
GNU General Public License v2.0
4.58k stars 366 forks source link

version: Do not put a slash in the version tag #386

Closed oliv3r closed 1 year ago

oliv3r commented 1 year ago

Many systems do not like having a / in the version tag. In some cases, we generate a version as head/branch, which even gets amplified if one uses dev/feature as a branch name.

So lets drop these slashes to avoid potential issues.

Closes #358

yrutschle commented 1 year ago

Does that actually happen? it seems that only git describe --all --long would return a slash, and I don't see it would get called as the other two alternative should always work? (IIRC I didn't write that part, or at least I can't see the point of those 3 alternatives, I'd expect the first one to always succeed as long as git is present)

oliv3r commented 1 year ago

Does that actually happen? it seems that only git describe --all --long would return a slash, and I don't see it would get called as the other two alternative should always work? (IIRC I didn't write that part, or at least I can't see the point of those 3 alternatives, I'd expect the first one to always succeed as long as git is present)

well both the reporter from #358 as myself (on my branch) ran into it, it's actually true.

Personally, I use this algorithm: https://gitlab.com/esbs/package_builder-alpine/-/blob/master/bin/package_builder-alpine.sh#L76

yrutschle commented 1 year ago

fair enough -- thanks for the fix