search

ysak-y / flutter_audio_capture

Package to capture audio stream buffer for flutter
MIT License
23 stars 30 forks source link

Update AudioCapture.swift #17

Closed DaveHineman closed 1 year ago

DaveHineman commented 1 year ago

Changes to init() to eliminate constant audio resets. .defaultToSpeaker and .mergeWithOthers added to improve compatibility with other plugins. I also added some code from the flutter audio_streams package that keeps the stream from dying when changing pages in an app (from https://pub.dev/packages/audio_streams).

ysak-y commented 1 year ago

Hi @DaveHineman !! Thank you for submitting PR!! btw, why did you close it? It seems good modification!!

DaveHineman commented 1 year ago

It’s my first pull request, so I wasn’t sure if I was the one to close it. I can do it. When will you be able to put out a new version?On Dec 16, 2022, at 8:55 PM, ymd @.***> wrote: Hi @DaveHineman !! Thank you for submitting PR!! btw, why did you close it? It seems good modification!!

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

ysak-y commented 1 year ago

@DaveHineman Okay, I restored and approved this PR. Please click "Merge pull request" button.

DaveHineman commented 1 year ago

Sorry, there was only a ‘close pull request’ button. I clicked what looked like a ‘reload’ button by your name and then it said ‘resubmitting pull request.’

Looks like an accidentally closed this when I cleaned up my first pull attempts. I’ll start over.

On Dec 17, 2022, at 12:04 AM, ymd @.***> wrote:

@DaveHineman https://github.com/DaveHineman Okay, I restored and approved this PR. Please click "Merge pull request" button.

— Reply to this email directly, view it on GitHub https://github.com/ysak-y/flutter_audio_capture/pull/17#issuecomment-1356060168, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALXQ4DBIESLCTNGP63T3EQTWNVJX3ANCNFSM6AAAAAAS75UCDM. You are receiving this because you were mentioned.

DaveHineman commented 1 year ago

I really don't care about the credentials, feel free to just add the changes yourself and roll the version. Later I will learn how to do a pull request properly.