ysard / mintrayr

Mozilla extension: Minimize windows into the system tray (Firefox, Thunderbird, Seamonkey, Instantbird)
https://addons.thunderbird.net/en-US/thunderbird/addon/minimizetotray-reanimated/
Mozilla Public License 2.0
130 stars 14 forks source link

added support for windows unpacking #1

Closed kolinger closed 5 years ago

kolinger commented 5 years ago

Added support for windows unpacking, also added hint for python dependencies.

With this fix extension is working on Windows 10 x64 with Thunderbird 60.0.

BTW: Nice workaround how you unpacking extension manually 👍. I did not know that Thunderbird JS has such power 💪

ysard commented 5 years ago

Well seen, it was indeed a problem of path under Windows. Thank you for the fix ! It's the fault of the newURI() method that returns something like this: // jar: file: /// C: /Users/xxx/AppData/Roaming/Thunderbird/Profiles/xxx.default/extensions/mintrayr@tn123.ath.cx.xpi! /modules/trayservice.jsm

I did not know that Thunderbird JS has such power Yes and it is very dangerous because any addon can modify any file on the hard drive... It is amazing that there have not been more problems in the past with such APIs.