search

ysard / mintrayr

Mozilla extension: Minimize windows into the system tray (Firefox, Thunderbird, Seamonkey, Instantbird)
https://addons.thunderbird.net/en-US/thunderbird/addon/minimizetotray-reanimated/
Mozilla Public License 2.0
130 stars 14 forks source link

unpacking will fail if file already exists #2

Closed kolinger closed 5 years ago

kolinger commented 5 years ago

Unpacking will fail if file already exists. Tested on Windows.

Steps to reproduce:

  1. install extension - unpacking will happen, everything works
  2. close thunderbird
  3. open thunderbird again
  4. extension will trigger unpacking again, will try to overwrite existing files and this will fail, unpacked files are ready-only, so access is denied, extension crashes

Solution - skip existing files when unpacking.

Files will not change. So overwriting is not necessary. Also this saves some IO overhead and time on startup.

ysard commented 5 years ago

Thank you, I agree with that, it's an oversight :)