search

ysbaddaden / prax

Rack proxy server for development
http://ysbaddaden.github.io/prax/
Other
475 stars 49 forks source link

Fix integration with Rack::File #137

Open packrat386 opened 7 years ago

packrat386 commented 7 years ago

Changed intoduced to rack in the commit below broke the way that prax uses Rack::File. This change uses the new API.

https://github.com/rack/rack/commit/f244d4 https://github.com/rack/rack/commit/ed0d8c

ysbaddaden commented 7 years ago

Is it backward compatible?

packrat386 commented 7 years ago

With old versions of Rack? Probably not, but given that this change was made to Rack over a year ago I think it's fair to say that in versions of prax moving forward we're only going to support Rack >= 2.0.0

ysbaddaden commented 7 years ago

The Ruby version of Prax is maintenance only (use the Crystal version). I'd like to avoid introducing a change for Rack 2+ that breaks compatibility with older versions of Rack.

We can't use Rack::VERSION but maybe use Rack::RELEASE to support both versions?

packrat386 commented 7 years ago

@ysbaddaden how does the most recent version look?