ysbaddaden / prax

Rack proxy server for development
http://ysbaddaden.github.io/prax/
Other
475 stars 49 forks source link

add support for explicit subdomains #47

Closed jneen closed 10 years ago

jneen commented 11 years ago

this way, if you link something as foo.example, it will be reachable from foo.example.dev, or more generally $prefix.foo.example.dev.

This is needed at my work since we have several apps that need to run on the same domain, so it's easier to set up all the apps as app-name.company-domain.dev

This should be a backwards-compatible change, since arbitrary subdomains still work in the case that was supported before.

jneen commented 10 years ago

bump. Any update on this? I forgot if you were waiting for code from me - I'm still using my personal fork for now.

jneen commented 10 years ago

Bump. ...?

ysbaddaden commented 10 years ago

Sorry I was lost in work. Finally got it merged!

jneen commented 10 years ago

Awesome! Thanks <3

ysbaddaden commented 10 years ago

Could you port that PR to the unstable branch? That would be awesome.

Sadly I can't just cherry-pick it because unstable is a complete rewrite (yet it's stable enough that I use it daily).

jneen commented 10 years ago

yikes, okay I'll give it a look.

jneen commented 10 years ago

See #54