ysbaddaden / prax

Rack proxy server for development
http://ysbaddaden.github.io/prax/
Other
475 stars 49 forks source link

Fix errors thrown by Rack::Lint #76

Closed adamcrown closed 10 years ago

adamcrown commented 10 years ago

According to Rack::Lint there are a couple small issues with prax's Rack spec validation. These were the errors that were being thrown.

rack.input #<StringIO> does not have ASCII-8BIT as its external encoding

and

env variable SERVER_PORT has non-string value

If you'd like to test it yourself here's the simple config.ru I used.

require 'rack/lint'
use Rack::Lint
run ->(*) { [200, {'Content-Type' => 'text/html'}, ['Lint?']] }

I ran into these while trying to run a Middleman site via prax in case anybody runs into the same issue.

ysbaddaden commented 10 years ago

Thanks! I'll look at it ASAP, and add Rack::Lint to the test suite.