search

ysbaddaden / sdl.cr

SDL2 bindings for Crystal
102 stars 32 forks source link

Support Crystal 1.0.0 onwards, perhaps? #37

Closed Erquint closed 3 years ago

Erquint commented 3 years ago

While crystal attribute is marked "optional", shards assumes it to be < 1.0.0 when missing and fails to install with the following error:

Unable to satisfy the following requirements:

- `crystal (< 1.0.0)` required by `sdl 0.1.0+git.commit.b674fbaaf9ff8505b3e76cbd43528d2f0cfdbdc2`
Failed to resolve dependencies, try updating incompatible shards or use --ignore-crystal-version as a workaround if no update is available.

See if this version range seems legit for you.

ysbaddaden commented 3 years ago

Sigh. The crystal version field was meant to be informational only.

It looks fine.

ysbaddaden commented 3 years ago

Is it working as expected, now?

Erquint commented 3 years ago

Should 🤷‍♂️. I'd probably have to change the shard in my project's dependencies to my fork to test that ahead of time… Ehh… that's a bit of a chore.

Erquint commented 3 years ago

Wait up. I'm trying to test.

ysbaddaden commented 3 years ago

I missed the "expected to be < 1.0.0" part. That's awful. Thanks for trying to fix this :)

Erquint commented 3 years ago

Ran into some issues with shards, partly due to user error, which took time to figure out — sorry for the delay.

Turns out it works with even just the major version. (">= 0.36, < 2") Although the full semver just looks nicer. (">= 0.36.1, < 2.0.0")

If you prefer the full one — the PR should be safe to merge now.

ysbaddaden commented 3 years ago

Thank you!