Closed mileeco closed 8 years ago
Is this a complete list? I have to figure out the exact height we want this at. How bad is it if someone's head gets close to the nav?
I increased the header height a bit. Let me know if it is too much, or if there are still cases that are too tall. we may need to bump a few people up/down specifically in the css, which would not be too hard, just a bit extra on dev time.
@iamnbutler Went through all the students again and nope, everything looks great now!
I didn't see this yesterday, but Jinah's photo looks "broken". I know it's cause she didn't get her photo taken, but can we just take it out for hers then? I'll figure out what we can put there post-launch. Thanks!
Ahhh I really wish we had just tracked her down 😞 Yeah I'll have to add an student identifer to the page then, which means iI can do some height-based adjustments. Since her page is so unfinished in general I wouldn't worry too much about it.
Sounds good!!!
Oh, I inadvertently resolved this in 42ec71e. I'll leave this open in case we want to revisit the image.
I think this is done. Can re-open if issues still exist.
Heads cut off for a few students (the taller ones)... Also noticed that the copy on the left is not middle-aligned vertically, but that can be tackled post launch.