search

yse / easy_profiler

Lightweight profiler library for c++
MIT License
2.14k stars 184 forks source link

rename function names related to versions #188

Open limingchina opened 3 years ago

limingchina commented 3 years ago

The current function name is quite generic and it's easy to conflict with other functions in a project since they're C functions

kevswims commented 1 week ago

The now() function also conflicts with other libraries (libsystemd in our case). Can renaming that be added to this PR?

limingchina commented 1 week ago

The now() function also conflicts with other libraries (libsystemd in our case). Can renaming that be added to this PR?

Renamed. However, not sure if the author is actively accepting PRs and merge that to the mainline.

yse commented 1 week ago

Hi! There are a few changes that I should merge and make new major release. The fix is good to up a major version, also migrate to Qt6. Thank you for your contribution. I think I will find time and energy to make project more freshy)