search

ysgard / d-struct

Atom syntax highlighting and snippets for the D programming language.
MIT License
10 stars 7 forks source link

Botched Git History #11

Open MggMuggins opened 7 years ago

MggMuggins commented 7 years ago

Yeah, I just completely changed this issue. I emailed ysgard about the original topic.

Anyway, I'd really like to ask for advice on going forward with that awful mess I made back in February trying to get dub for Linux working. I squashed all of those down to one (plus some new contribs (so don't feel pressure to merge...), and pushed them to github. Let me know what you think, and I'll try and get the autocomplete provider going.

ysgard commented 7 years ago

Thanks for your work on this @MggMuggins! Regretfully I'm swamped with work right now, but I'll take a look at it on the weekend.

MggMuggins commented 7 years ago

Awesome, thanks! I don't think my solution is ideal, but it could probably work. Meantime I'm implementing an autocomplete provider for autocomplete+ using the dcd. As is usual, it's way harder than it needs to be, but I am making progress. In any case, that's partially why my solution isn't ideal; I didn't know how to pull all of my old commits into one squash without including my newest work on the autocomplete provider.

ysgard commented 7 years ago

So I tested the changes you made, and as far as I can tell, the package works on Linux. However I neglected to include your changes the last time I published, my apologies! I'm pretty new to developing atom packages.

Anyways if you upgrade to the latest version 1.1.0 it should work on Linux. Let me know if it doesn't. For reference I tested on debian 9.0/x86_64

MggMuggins commented 7 years ago

Alright. I kinda screwed up when I was doing some other stuff and accidentally squashed in some new edits to the squashing the commits from that other fix. I'd really like to squash all that nasty merge history into two commits: Leave my first one as is, and squash the next five (including merges) into one. That way things just end up looking nicer. I'll do a new local clone here soon and hopefully be able to clear that up.