OCL error: implicit declarations are not allowed

ysh329 commented 6 years ago

>>> [ERROR] kernel build log: <source>:24:5: error: implicit declarations are not allowed
    AddDot(K, &a[0 * M + row], M, &b[(col+0) * N + 0], &c[(col+0)*N + row]);
    ^

<source>:25:5: error: implicit declarations are not allowed
    AddDot(K, &a[0 * M + row], M, &b[(col+1) * N + 0], &c[(col+1)*N + row]);
    ^

<source>:26:5: error: implicit declarations are not allowed
    AddDot(K, &a[0 * M + row], M, &b[(col+2) * N + 0], &c[(col+2)*N + row]);
    ^

<source>:27:5: error: implicit declarations are not allowed
    AddDot(K, &a[0 * M + row], M, &b[(col+3) * N + 0], &c[(col+3)*N + row]);
    ^

error: Compiler frontend failed (error code 59)

ysh329 commented 6 years ago

fixed. This issue is caused by undefined AddDot function before use in mat_mult. Thus, add following line before function mat_mult_2:

__kernel void AddDot(const int K, __global const CL_INPUT_TYPE *x, const int incx, __global const CL_INPUT_TYPE *y, __global CL_INPUT_TYPE *gamma);

Full code is below:

#define A(i,j) a[ (j) * lda + (i) ]
#define B(i,j) b[ (j) * ldb + (i) ]
#define C(i,j) c[ (j) * ldc + (i) ]

__kernel void AddDot(const int K, __global const CL_INPUT_TYPE *x, const int incx, __global const CL_INPUT_TYPE *y, __global CL_INPUT_TYPE *gamma);

__kernel void mat_mult_2(const int M, const int N, const int K, __global const CL_INPUT_TYPE *a, __global const CL_INPUT_TYPE *b, __global CL_INPUT_TYPE *c) {
    const int col = get_global_id(0) << 2;
    const int row = get_global_id(1);

    AddDot(K, &a[0 * M + row], M, &b[(col+0) * N + 0], &c[(col+0)*N + row]);
    AddDot(K, &a[0 * M + row], M, &b[(col+1) * N + 0], &c[(col+1)*N + row]);
    AddDot(K, &a[0 * M + row], M, &b[(col+2) * N + 0], &c[(col+2)*N + row]);
    AddDot(K, &a[0 * M + row], M, &b[(col+3) * N + 0], &c[(col+3)*N + row]);

}

__kernel void AddDot(const int K, __global const CL_INPUT_TYPE *x, const int incx, __global const CL_INPUT_TYPE *y, __global CL_INPUT_TYPE *gamma) {

    for (int p = 0; p < K; p++) {
        *gamma += x[ p * incx ] * y[ p ];
    }   
}

ysh329 commented 6 years ago

This issue can be closed. However, the execution result is wrong (correct rate is 0.0). :sob:

ysh329 / OpenCL-101

OCL error: implicit declarations are not allowed #17