thanks für this great project. As mentioned in #13 you asked for support of the Kotlin DSL. Therefore, I migrated the Groovy scripts to the Kotlin DSL. Feel free to give me feedback and ask questions when they arise in the review.
Changes
Migrate the build scripts, except gradle-mvn-push.gradle, to the Kotlin DSL. See below
Use the buildSrc for versions and depdendencies. The usage of buildSrc could be extended. So far, I only used it for parts that are required in the migration.
Maven Publish Plugin
I didn't migrate the gradle-mvn-push.gradle to the Kotlin DSL because it uses the outdated Maven Plugin to publish the artifact. This plugin uses Groovy closures instead of Gradle actions, which makes it harder to migrate. I started with it, but stopped for two reasons:
The migration with the withGroovyBuilder helper methods and Strings results in poorly to ready an maintain code.
Also, I encountered some issue with lazy evaluated properties and there usage inside of the GroovyBuilderScope.
Gradle supports mixed Groovy and Kotlin scripts, so the project still works. The best solution to get rid of the Groovy script is, to use the newer Maven Publishing Plugin. This is also recommended in the Maven Plugin documentation. I could tackle that in another PR, when this is ok for you.
Improved Versions Management
The project already uses the Versions Plugin and the usage could be extended to better check for updates. An alternative is the Refresh Versions Plugin, which automatically generates the version files.
yshrsmz
commented
5 years ago
Hi,
thanks für this great project. As mentioned in #13 you asked for support of the Kotlin DSL. Therefore, I migrated the Groovy scripts to the Kotlin DSL. Feel free to give me feedback and ask questions when they arise in the review.
Changes
gradle-mvn-push.gradle, to the Kotlin DSL. See belowMaven Publish Plugin
I didn't migrate the
gradle-mvn-push.gradleto the Kotlin DSL because it uses the outdated Maven Plugin to publish the artifact. This plugin uses Groovy closures instead of Gradle actions, which makes it harder to migrate. I started with it, but stopped for two reasons:withGroovyBuilderhelper methods and Strings results in poorly to ready an maintain code.Gradle supports mixed Groovy and Kotlin scripts, so the project still works. The best solution to get rid of the Groovy script is, to use the newer Maven Publishing Plugin. This is also recommended in the Maven Plugin documentation. I could tackle that in another PR, when this is ok for you.
Improved Versions Management
The project already uses the Versions Plugin and the usage could be extended to better check for updates. An alternative is the Refresh Versions Plugin, which automatically generates the version files.