search

yshui / picom

A lightweight compositor for X11
Other
3.93k stars 575 forks source link

backend: gl: don't leak gl resources #1183

Closed yshui closed 4 months ago

yshui commented 4 months ago

Merge after #1179

yshui commented 4 months ago

glXDestroyContext should free everything anyway, but it's still a good thing to do

codecov[bot] commented 4 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a39cd94) 36.56% compared to head (f265e04) 36.48%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/yshui/picom/pull/1183/graphs/tree.svg?width=650&height=150&src=pr&token=NRSegi0Gze&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)](https://app.codecov.io/gh/yshui/picom/pull/1183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) ```diff @@ Coverage Diff @@ ## next #1183 +/- ## ========================================== - Coverage 36.56% 36.48% -0.09% ========================================== Files 50 50 Lines 11543 11555 +12 ========================================== - Hits 4221 4216 -5 - Misses 7322 7339 +17 ``` | [Files](https://app.codecov.io/gh/yshui/picom/pull/1183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) | Coverage Δ | | |---|---|---| | [src/backend/gl/gl\_common.c](https://app.codecov.io/gh/yshui/picom/pull/1183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2JhY2tlbmQvZ2wvZ2xfY29tbW9uLmM=) | `26.23% <91.66%> (+0.96%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/yshui/picom/pull/1183/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)