yshui / picom

A lightweight compositor for X11
Other
3.93k stars 575 forks source link

Fix: unbreak compilation on OpenBSD #1188

Closed yukiteruamano closed 4 months ago

yukiteruamano commented 4 months ago

@yshui As you had asked me, the final changes each in their own commit, I have already compiled the binary and it works without problems. Take a look.

picom-unbreak-openbsd.log

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0f22b70) 36.62% compared to head (023103c) 36.62%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/yshui/picom/pull/1188/graphs/tree.svg?width=650&height=150&src=pr&token=NRSegi0Gze&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)](https://app.codecov.io/gh/yshui/picom/pull/1188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) ```diff @@ Coverage Diff @@ ## next #1188 +/- ## ======================================= Coverage 36.62% 36.62% ======================================= Files 50 50 Lines 11555 11555 ======================================= Hits 4232 4232 Misses 7323 7323 ``` | [Files](https://app.codecov.io/gh/yshui/picom/pull/1188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) | Coverage Δ | | |---|---|---| | [src/picom.c](https://app.codecov.io/gh/yshui/picom/pull/1188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL3BpY29tLmM=) | `62.21% <ø> (ø)` | |
yshui commented 4 months ago

And you second commit's message is copied twice

yshui commented 4 months ago

@yukiteruamano there are some extra considerations i just found out about the opengl problem. we might go a different route, so let's merge the sched fix first

yshui commented 4 months ago

@yukiteruamano thanks for the PR, and for being patient with the feedbacks. :+1:

yukiteruamano commented 4 months ago

@yshui Not problem, thanks for you help, my knowledge in C/git is limited, but with this changes I have been able to unbreak the build and use picom v11+ without problems with amdgpu on OpenBSD, and if the changes arrive and are maintained upstream they will generate fewer problems to compile and maintain the project on OpenBSD.