search

yshui / picom

A lightweight compositor for X11 with animation support
https://picom.app/
Other
4.1k stars 585 forks source link

Use libepoxy #1189

Closed yshui closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (dff77aa) 36.60% compared to head (642a43a) 36.21%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/yshui/picom/pull/1189/graphs/tree.svg?width=650&height=150&src=pr&token=NRSegi0Gze&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)](https://app.codecov.io/gh/yshui/picom/pull/1189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) ```diff @@ Coverage Diff @@ ## next #1189 +/- ## ========================================== - Coverage 36.60% 36.21% -0.39% ========================================== Files 50 50 Lines 11558 11469 -89 ========================================== - Hits 4231 4154 -77 + Misses 7327 7315 -12 ``` | [Files](https://app.codecov.io/gh/yshui/picom/pull/1189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) | Coverage Δ | | |---|---|---| | [src/backend/gl/gl\_common.c](https://app.codecov.io/gh/yshui/picom/pull/1189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2JhY2tlbmQvZ2wvZ2xfY29tbW9uLmM=) | `26.23% <100.00%> (ø)` | | | [src/backend/gl/gl\_common.h](https://app.codecov.io/gh/yshui/picom/pull/1189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2JhY2tlbmQvZ2wvZ2xfY29tbW9uLmg=) | `19.44% <ø> (-10.79%)` | :arrow_down: | | [src/backend/gl/glx.c](https://app.codecov.io/gh/yshui/picom/pull/1189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2JhY2tlbmQvZ2wvZ2x4LmM=) | `32.01% <ø> (-6.50%)` | :arrow_down: | | [src/opengl.h](https://app.codecov.io/gh/yshui/picom/pull/1189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL29wZW5nbC5o) | `60.46% <ø> (ø)` | | | [src/vblank.c](https://app.codecov.io/gh/yshui/picom/pull/1189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL3ZibGFuay5j) | `0.00% <ø> (ø)` | | | [src/opengl.c](https://app.codecov.io/gh/yshui/picom/pull/1189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL29wZW5nbC5j) | `0.00% <0.00%> (ø)` | | | [src/log.c](https://app.codecov.io/gh/yshui/picom/pull/1189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2xvZy5j) | `67.06% <16.66%> (+1.94%)` | :arrow_up: | | [src/backend/gl/egl.c](https://app.codecov.io/gh/yshui/picom/pull/1189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2JhY2tlbmQvZ2wvZWdsLmM=) | `17.24% <33.33%> (-7.12%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/yshui/picom/pull/1189/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)
yukiteruamano commented 7 months ago

@yshui @absolutelynothelix I'm going to try the changes in OpenBSD, there shouldn't be any problems with using libepoxy, but it's better to clear up any doubts

absolutelynothelix commented 7 months ago

@yukiteruamano, we now have an openbsd ci so picom should at least always build there. sorry for the inconvenience!

yukiteruamano commented 7 months ago

Yeah, I see that and I test the last changes, compile without issues