yshui / picom

A lightweight compositor for X11 with animation support
https://picom.app/
Other
4.1k stars 585 forks source link

Cache window properties used in c2 conditions #1201

Closed yshui closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: 252 lines in your changes are missing coverage. Please review.

Comparison is base (9e5e6ae) 37.52% compared to head (22116ec) 37.33%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/yshui/picom/pull/1201/graphs/tree.svg?width=650&height=150&src=pr&token=NRSegi0Gze&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)](https://app.codecov.io/gh/yshui/picom/pull/1201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) ```diff @@ Coverage Diff @@ ## next #1201 +/- ## ========================================== - Coverage 37.52% 37.33% -0.19% ========================================== Files 51 51 Lines 11631 11765 +134 ========================================== + Hits 4364 4392 +28 - Misses 7267 7373 +106 ``` | [Files](https://app.codecov.io/gh/yshui/picom/pull/1201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) | Coverage Δ | | |---|---|---| | [src/atom.h](https://app.codecov.io/gh/yshui/picom/pull/1201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2F0b20uaA==) | `100.00% <ø> (ø)` | | | [src/c2.h](https://app.codecov.io/gh/yshui/picom/pull/1201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2MyLmg=) | `100.00% <ø> (ø)` | | | [src/picom.c](https://app.codecov.io/gh/yshui/picom/pull/1201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL3BpY29tLmM=) | `62.11% <100.00%> (+0.04%)` | :arrow_up: | | [src/win.h](https://app.codecov.io/gh/yshui/picom/pull/1201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL3dpbi5o) | `78.12% <ø> (ø)` | | | [src/event.c](https://app.codecov.io/gh/yshui/picom/pull/1201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2V2ZW50LmM=) | `69.29% <0.00%> (-0.57%)` | :arrow_down: | | [src/win.c](https://app.codecov.io/gh/yshui/picom/pull/1201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL3dpbi5j) | `68.35% <83.33%> (+0.02%)` | :arrow_up: | | [src/atom.c](https://app.codecov.io/gh/yshui/picom/pull/1201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2F0b20uYw==) | `51.89% <46.29%> (-29.36%)` | :arrow_down: | | [src/c2.c](https://app.codecov.io/gh/yshui/picom/pull/1201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2MyLmM=) | `56.80% <25.68%> (-4.54%)` | :arrow_down: |
yshui commented 7 months ago

I say merge this and let the bug reports flow in.

Plus with this merged i should be able to write many unit tests for this