search

yshui / picom

A lightweight compositor for X11
Other
3.93k stars 575 forks source link

c2: remove type specifiers #1205

Closed yshui closed 4 months ago

yshui commented 4 months ago

Same logic as the format specifiers, we just use what the X server reports, asking the user for the type is just going to be confusing.

codecov[bot] commented 4 months ago

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (a7d599e) 37.54% compared to head (0440f40) 37.52%.

:exclamation: Current head 0440f40 differs from pull request most recent head 198da19. Consider uploading reports for the commit 198da19 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/yshui/picom/pull/1205/graphs/tree.svg?width=650&height=150&src=pr&token=NRSegi0Gze&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)](https://app.codecov.io/gh/yshui/picom/pull/1205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) ```diff @@ Coverage Diff @@ ## next #1205 +/- ## ========================================== - Coverage 37.54% 37.52% -0.03% ========================================== Files 51 51 Lines 11657 11630 -27 ========================================== - Hits 4377 4364 -13 + Misses 7280 7266 -14 ``` | [Files](https://app.codecov.io/gh/yshui/picom/pull/1205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) | Coverage Δ | | |---|---|---| | [src/x.c](https://app.codecov.io/gh/yshui/picom/pull/1205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL3guYw==) | `42.13% <100.00%> (+0.12%)` | :arrow_up: | | [src/x.h](https://app.codecov.io/gh/yshui/picom/pull/1205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL3guaA==) | `82.92% <33.33%> (-3.92%)` | :arrow_down: | | [src/c2.c](https://app.codecov.io/gh/yshui/picom/pull/1205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2MyLmM=) | `61.33% <51.42%> (+0.41%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/yshui/picom/pull/1205/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)