yshui / picom

A lightweight compositor for X11 with animation support
https://picom.app/
Other
4.1k stars 585 forks source link

core: disable realtime scheduling by default #1213

Closed yshui closed 7 months ago

yshui commented 7 months ago

And add a --realtime option for enabling it.

Signed-off-by: Yuxuan Shui yshuiv7@gmail.com

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 36.49%. Comparing base (cc8e0a9) to head (dc3271e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/yshui/picom/pull/1213/graphs/tree.svg?width=650&height=150&src=pr&token=NRSegi0Gze&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)](https://app.codecov.io/gh/yshui/picom/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) ```diff @@ Coverage Diff @@ ## next #1213 +/- ## ========================================== - Coverage 36.72% 36.49% -0.23% ========================================== Files 51 51 Lines 11936 11949 +13 ========================================== - Hits 4383 4361 -22 - Misses 7553 7588 +35 ``` | [Files](https://app.codecov.io/gh/yshui/picom/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) | Coverage Δ | | |---|---|---| | [src/config.h](https://app.codecov.io/gh/yshui/picom/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL2NvbmZpZy5o) | `23.52% <ø> (ø)` | | | [src/options.c](https://app.codecov.io/gh/yshui/picom/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL29wdGlvbnMuYw==) | `24.40% <0.00%> (-0.06%)` | :arrow_down: | | [src/utils.c](https://app.codecov.io/gh/yshui/picom/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL3V0aWxzLmM=) | `47.36% <0.00%> (-8.04%)` | :arrow_down: | | [src/picom.c](https://app.codecov.io/gh/yshui/picom/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL3BpY29tLmM=) | `61.02% <20.00%> (+0.04%)` | :arrow_up: | | [src/vblank.c](https://app.codecov.io/gh/yshui/picom/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL3ZibGFuay5j) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/yshui/picom/pull/1213/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)
yshui commented 7 months ago

Also --realtime being undocumented is intentional. I don't want to mislead people to think enabling this is useful, even we ourselves don't have hard evidence for it yet,

absolutelynothelix commented 7 months ago

i'm not sure if realtime should also be a configuration file option because toggling it at runtime doesn't work right now and making it so would require extra work. i suggest to have it only as a command line option, at least for now. what do you think?

yshui commented 7 months ago

@absolutelynothelix makes sense