Closed yshui closed 7 months ago
Attention: Patch coverage is 7.14286%
with 13 lines
in your changes are missing coverage. Please review.
Project coverage is 36.49%. Comparing base (
cc8e0a9
) to head (dc3271e
).
Also --realtime
being undocumented is intentional. I don't want to mislead people to think enabling this is useful, even we ourselves don't have hard evidence for it yet,
i'm not sure if realtime
should also be a configuration file option because toggling it at runtime doesn't work right now and making it so would require extra work. i suggest to have it only as a command line option, at least for now. what do you think?
@absolutelynothelix makes sense
And add a --realtime option for enabling it.
Signed-off-by: Yuxuan Shui yshuiv7@gmail.com