search

yshui / picom

A lightweight compositor for X11
Other
3.93k stars 575 forks source link

win: fix EWMH fullscreen detection #1217

Closed yshui closed 3 months ago

yshui commented 3 months ago

In win_update_prop_fullscreen, if _NET_WM_STATE is empty we exited early and forgot to set fullscreen to false.

Fixes #1216

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.36%. Comparing base (040cc10) to head (6de56c6).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/yshui/picom/pull/1217/graphs/tree.svg?width=650&height=150&src=pr&token=NRSegi0Gze&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)](https://app.codecov.io/gh/yshui/picom/pull/1217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) ```diff @@ Coverage Diff @@ ## next #1217 +/- ## ========================================== - Coverage 36.54% 36.36% -0.18% ========================================== Files 51 51 Lines 11952 11950 -2 ========================================== - Hits 4368 4346 -22 - Misses 7584 7604 +20 ``` | [Files](https://app.codecov.io/gh/yshui/picom/pull/1217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) | Coverage Δ | | |---|---|---| | [src/win.c](https://app.codecov.io/gh/yshui/picom/pull/1217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL3dpbi5j) | `66.96% <ø> (-1.13%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/yshui/picom/pull/1217/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)