search

yshui / picom

A lightweight compositor for X11
Other
3.92k stars 576 forks source link

core: let destroyed window go through the preprocess loop one last time #1231

Closed yshui closed 2 months ago

yshui commented 2 months ago

Some necessary damage calculation happens there. For example, if a window was rendered last frame but is destroyed this frame, the preprocess loop should add the window to damage. If the destroyed window is freed before the preprocess loop, that damage will be missed.

Fixes #1229 #1230 Fixes: 3b6e003ca1212ba348f8ad9ca01fb576d5aff737

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.35%. Comparing base (a5e3de4) to head (72c82a3).

:exclamation: Current head 72c82a3 differs from pull request most recent head 6c9a2a4. Consider uploading reports for the commit 6c9a2a4 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/yshui/picom/pull/1231/graphs/tree.svg?width=650&height=150&src=pr&token=NRSegi0Gze&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)](https://app.codecov.io/gh/yshui/picom/pull/1231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) ```diff @@ Coverage Diff @@ ## next #1231 +/- ## ========================================== + Coverage 37.34% 37.35% +0.01% ========================================== Files 54 54 Lines 11965 11963 -2 ========================================== + Hits 4468 4469 +1 + Misses 7497 7494 -3 ``` | [Files](https://app.codecov.io/gh/yshui/picom/pull/1231?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui) | Coverage Δ | | |---|---|---| | [src/picom.c](https://app.codecov.io/gh/yshui/picom/pull/1231?src=pr&el=tree&filepath=src%2Fpicom.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui#diff-c3JjL3BpY29tLmM=) | `60.65% <100.00%> (+0.03%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/yshui/picom/pull/1231/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yuxuan+Shui)