search

yshui / picom

A lightweight compositor for X11 with animation support
https://picom.app/
Other
4.15k stars 589 forks source link

experimental xrender - unredir crash, the 2nd #239

Closed aufkrawall closed 5 years ago

aufkrawall commented 5 years ago

Hello yhsui, as mentioned there, this issue is back since commit eecee130b8d7f5b5e9bb735a1e7979c35177729f https://github.com/yshui/compton/issues/189

Attached is a debug log, crash dump and compton binary. compton.zip

yshui commented 5 years ago

thanks.

this is related to getting a ShapeNotify in the same cycle the window is unmap, i haven't found the cause yet. if you can reproduce this with a debug build of compton, it would be helpful.

aufkrawall commented 5 years ago

Yeah, I can reliably reproduce it simply by doing alt + tabbing out of vkquake.

yshui commented 5 years ago

@aufkrawall can you attach the dump and binary from a debug build?

but i think i know where the problem is now, will fix once i get back to my computer.

aufkrawall commented 5 years ago

Ah, yeah. I didn't enable debug build in meson.

yshui commented 5 years ago

Ah, yeah. I didn't enable debug build in meson.

Can you create a debug build?

aufkrawall commented 5 years ago

Ah, yeah. I didn't enable debug build in meson.

Can you create a debug build?

Of course, stay tuned.

aufkrawall commented 5 years ago

Same content as above, but with debug build: compton2.zip

yshui commented 5 years ago

@aufkrawall should've been fixed, can you try the latest next?

aufkrawall commented 5 years ago

@yshui Haven't tested with the same AMD GPU system, but on my Intel notebook it still crashes.

yshui commented 5 years ago

@yshui https://github.com/yshui Haven't tested with the same AMD GPU system, but on my Intel notebook it still crashes.

that's odd, i cannot reproduce it anymore. could be a different crash?

can you attach the newer log/dump? thanks.

aufkrawall commented 5 years ago

Here we go again: compton3.zip

yshui commented 5 years ago

i found the cause. it's because the window is unmapped the same cycle the screen is redirected, so it didn't get a chance to acquire the pixmap

solving this one will be a bit trickier

yshui commented 5 years ago

@aufkrawall hopefully it's fixed now.

aufkrawall commented 5 years ago

@yshui Yep, issue's gone here. Thanks once again. Having proper auto unredirect is really a great feature of Compton.