ysig / GraKeL

A scikit-learn compatible library for graph kernels
https://ysig.github.io/GraKeL/
Other
587 stars 96 forks source link

Remove win32 builds altogether #85

Closed eddiebergman closed 1 year ago

eddiebergman commented 1 year ago

tldr; Fully dropped building prebuilt binaries for win32 because scipy finally did it too, they said they would a while ago but only fully did it 2 days back.


So it seems that Scipy updated to 1.9.2 2 days ago (08/10/22) and as part of that, they stopped releasing win32 completely. This meant when building GraKeL, it would download the source of scipy and try to compile it manually.

Ctrl + f for win32 and you'll see they dropped it between the two versions

It seems odd they would drop it with a minor release so I went looking at their github.

One issue specifically asks about Python 3.10 which I had disabled previously but one of the maintainers replied in there, saying they would drop win32 wheels from scipy>=1.8. There was however, still win32 wheels available from 1.8.0 -> 1.9.1.

There is also an issue from 2 days ago where they apparently stated they updated their build infrastructure which I guess is where they finally dropped it. Looking at the workflow runs they linked in that issue, there's no build for win32 at all so I guess from this point on it's fully dropped support for pre-built win32 wheels.

So the choices are essentially (in order of recommendation):

I went with the first because, well, it's easiest and upperbounding will lead to similar problems in the future, someone want's GraKeL and the newest scikit learn, and they will both have conflicting scipy versions.


codecov[bot] commented 1 year ago

Codecov Report

Merging #85 (a345c30) into master (af0049c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   69.25%   69.25%           
=======================================
  Files          37       37           
  Lines        7059     7059           
=======================================
  Hits         4889     4889           
  Misses       2170     2170           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more