search

ysimonx / node-red-contrib-melcloud

node-red node for mitsubishi with melcloud API
MIT License
15 stars 5 forks source link

Faulty code in melcoud-connect.js #12

Closed Meewis closed 1 year ago

Meewis commented 1 year ago

After this fault and a crash of NodeRed, I got this message: 25 Oct 03:37:24 - [red] Uncaught Exception: 25 Oct 03:37:24 - [error] ReferenceError: msg is not defined at /data/node_modules/node-red-contrib-melcloud/melcloud-connect.js:256:44 at runMicrotasks () at processTicksAndRejections (node:internal/process/task_queues:96:5)

The solution: At line 256: }).catch(err => { This should be: }).catch(msg => {

Kind regards, Wilco

ysimonx commented 1 year ago

Hello

let's fix it ;-)

thx

ysimonx commented 1 year ago

Hi @Meewis

I just pushed a little fix with https://flows.nodered.org/node/node-red-contrib-melcloud can you try please ?

Meewis commented 1 year ago

Test is running, it needs some days to be sure of the good result...

Meewis commented 1 year ago

As far I can see, it works alright, no problems.

ysimonx commented 1 year ago

Thx