Use MetaInspector's best guess on page title when generating Non-OGP preview

ysk24ok / jekyll-linkpreview

Jekyll plugin to generate link preview

https://rubygems.org/gems/jekyll-linkpreview

MIT License

29 stars 8 forks source link

Use MetaInspector's best guess on page title when generating Non-OGP preview #39

Closed Clpsplug closed 1 year ago

Clpsplug commented 1 year ago

Closes #38.

This PR changes the behavior of NonOpenGraphPropertiesFactory so that the title can be found even if the page doesn't write its <title> within its <head>. To be specific, one of the following elements will be used as the page title (if more than one is found, the earliest in this list is used:)

<meta property='title' ...>
<meta property='og:title' ...>
<title> within <head>
<title> within <body>
The first <h1> element within the page

ysk24ok commented 1 year ago

Hmm, maybe because the test workflow doesn't have on.pull_request field, CI doesn't run for this PR. Merging this anyway it looks OK.