search

ysk24ok / jekyll-linkpreview

Jekyll plugin to generate link preview
https://rubygems.org/gems/jekyll-linkpreview
MIT License
29 stars 8 forks source link

Fix CI failing because of old rubygems #41

Closed Clpsplug closed 1 year ago

Clpsplug commented 1 year ago

Closes #40.

This patch adds gem update before bundle install, preventing errors related to old rubygems. On my side, the CI triggered on pushes seems to be running correctly.

I'm not sure if repository owners can accept this kind of PR from non-owners; if not, feel free to copy this patch and close this one.

(p.s., if you also want me to modify the CI so that we can see CI results here (per https://github.com/ysk24ok/jekyll-linkpreview/pull/39#issuecomment-1407357413) please tell me.)

ysk24ok commented 1 year ago

@Clpsplug The patch looks OK, but may I know why running gem update fixes the problem?

Clpsplug commented 1 year ago

@Clpsplug The patch looks OK, but may I know why running gem update fixes the problem?

To be honest with you, @ysk24ok, I thought I had an idea, but now I don't.

My first reasoning was that I read on StackOverflow that sudo gem update would update rubygems itself. However, through my testing, I found out that it does not. It merely updates installed gems.

Since I realized the patch did not do what I intended it to, I tried something that I knew would actually update Rubygems itself. However, that apparently broke everything again. This time, the appraisal gem broke; it's having trouble finding a specific gemfile.lock file or something.

I will look into this issue a bit more. This is weird, tbh...

ysk24ok commented 1 year ago

This time, the appraisal gem broke; it's having trouble finding a specific gemfile.lock file or something.

I fixed this by #43, so let me close this PR. Thank you for your efforts!