search

ysoftwareab / yplatform

Self-service bootstrap/build/CI/CD. Software and configuration that supports various cycles of software development.
Apache License 2.0
19 stars 7 forks source link

check `shell` calls #142

Closed andreineculau closed 4 years ago

andreineculau commented 4 years ago
text dump at https://raw.githubusercontent.com/rokmoln/zz-issues/master/tobiipro/support-firecloud/142.txt
check `shell` calls #142

   Open
   [57]andreineculau opened this issue Jan 24, 2020 · 0 comments
   Open

[58]check `shell` calls #142

   [59]andreineculau opened this issue Jan 24, 2020 · 0 comments
   Labels
   [60]question

Comments

   [61]@andreineculau
   Copy link (BUTTON) Quote reply
   Member

[62]@andreineculau [63]andreineculau commented [64]Jan 24, 2020

   shell calls in make are evaluated prior to the target's commands,
   therefore it is not equivalent to using ticks or $$(...) can lead to
   inconsistencies
   [65]@andreineculau [66]andreineculau added the [67]question label
   [68]Jan 24, 2020
   [69]@andreineculau [70]andreineculau added this to To do in [71]Public
   (Open Source) via automation [72]Jan 24, 2020
   [73]@ankitmth [74]ankitmth removed this from To do in [75]Public (Open
   Source) [76]Feb 19, 2020
andreineculau commented 4 years ago

cursory check shows only a few occurrences of $(shell ...) inside targets. Other occurrences outside targets cannot be replaced with native subshells $$(...)