search

ysoldak / fpvc-lady

FPV Combat events announcer
https://fpv-combat.com
MIT License
1 stars 2 forks source link

pause between reported hit and claim #7

Open chaos5235 opened 3 months ago

chaos5235 commented 3 months ago

at the moment there is a big timegap between the announcement of a hit and claim announcement - could that be reduced ?

chaos5235 commented 3 months ago

maybe the timegap is larger in demo mode. . . . have to re-check that in live

MrMap commented 3 months ago

The time gap is present also in non demo mode and kind of wasting time, especially when events come as bursts. "Target was hit ............................... Score to Bender"

Could it instead be announced like: "Target hit by Bender" ?

More time efficient.

ysoldak commented 1 month ago

I understand frustration. This was a sort of experiment to announce everything, since not all hits are claimed. It can be a HIT message comes and no CLAIM follow. In that case there will be just "Target was hit".

The lady announces these events separately, she does not keep track who hits whom, she just increments counters and makes an announcement, it's us humans make connection when announcements follow each other closely.

This also helps to keep the implementation simple[r], since we don't need to keep state on Lady's side and resolve who hit whom.

We could improve though, since clearly the current implementation makes announcements slower. We can try and wait a bit with "was hit" announcement and merge it with "Score" announcement if it comes, otherwise just announce "was hit" if CLAIM never comes.