generic sstable - Githubissues

ysono commented 3 years ago

Make struct SSTable generic.

The main motivation is secondary index.

Primary

File stores (Datum, OptDatum) tuples.
In-mem map stores {Datum: offset_in_primary_sstable_file}

Secondary

File stores (SubDatum, primary_sstable_file_and_offset_therein) tuples.
In-mem map stores {SubDatum: offset_in_secondary_sstable_file}

Make OptDatum more private.

OptDatum has become a concept internal to LSMTree only. I tried to make struct OptDatum private within lsm.rs, but the struct is tightly tied in with other code in serde.rs.

ysono commented 3 years ago

I might not need this for secondary indexes after all. I'm gonna rethink my approach.

btc commented 3 years ago

I might not need this for secondary indexes after all. I'm gonna rethink my approach.

ok

btc commented 3 years ago

feel free to merge when you're ready. not sure if you intend to merge this immediately.

ysono commented 3 years ago

Yep it's done. Thx

ysono / pancake

generic sstable #45