ysora / stripenn

Architectural stripe detection from 3D genome conformation data
17 stars 3 forks source link

can you explain Stripiness #10

Closed BenxiaHu closed 1 year ago

BenxiaHu commented 1 year ago

Hello, I am trying to understand the stripenn you develop. I am a little confused about Stripiness. Would you like to expalin why you use the following formula to calculate the Stripiness?

image
BenxiaHu commented 1 year ago

what does this matrix mean?

image
ysora commented 1 year ago

Hi Benxia! I tried to score the (vertical) stripes though stripiness measure. The stripe with high score would be (1) having high contrast with background. (high G_x) (2) having continuity within stripe. (low G_y) (3) high interactions within stripe. (high pixel values)

Now that I think about it, I'm not sure if the decision in (2) was reasonable because a stripe is made up of several loops and corresponding traces. So it is natural that the pixels within stripes are fluctuating along y-direction. Anyway, the matrix in the G_x,L term is what I devised to calculate the gradient between stripe and its left pixels.

Thanks!

Sora

rrdai77 commented 1 year ago

Why doesn't it work anymore after I installed it successfully?My code is as follows: stripenn compute --cool ESC.mcool::resolutions/10000 --out output_dir/ -k 16 -m 0.95,0.96,0.97,0.98,0.99 -s -n 18

ysora commented 1 year ago

Sorry for the inconvenience. Could you take a screenshot of error message? Thanks,

Sora

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: rrdai77 @.> Sent: Wednesday, April 5, 2023 3:51:00 AM To: ysora/stripenn @.> Cc: Yoon, Sora @.>; Comment @.> Subject: [External] Re: [ysora/stripenn] can you explain Stripiness (Issue #10)

Why doesn't it work anymore after I installed it successfully?My code is as follows: stripenn compute --cool ESC.mcool::resolutions/10000 --out output_dir/ -k 16 -m 0.95,0.96,0.97,0.98,0.99 -s -n 18

— Reply to this email directly, view it on GitHubhttps://github.com/ysora/stripenn/issues/10#issuecomment-1497068110, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABZHMJRR62GBYFXRYTFPA6DW7UP6JANCNFSM6AAAAAAU6RSFGU. You are receiving this because you commented.Message ID: @.***>

rrdai77 commented 1 year ago

Sorry for the inconvenience. Could you take a screenshot of error message? Thanks, Sora Get Outlook for Androidhttps://aka.ms/AAb9ysg ____ From: rrdai77 @.> Sent: Wednesday, April 5, 2023 3:51:00 AM To: ysora/stripenn @.> Cc: Yoon, Sora @.>; Comment @.> Subject: [External] Re: [ysora/stripenn] can you explain Stripiness (Issue #10) Why doesn't it work anymore after I installed it successfully?My code is as follows: stripenn compute --cool ESC.mcool::resolutions/10000 --out output_dir/ -k 16 -m 0.95,0.96,0.97,0.98,0.99 -s -n 18 — Reply to this email directly, view it on GitHub<#10 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABZHMJRR62GBYFXRYTFPA6DW7UP6JANCNFSM6AAAAAAU6RSFGU. You are receiving this because you commented.Message ID: @.***>

My code is as follows: image Then a screenshot of error message: 659eb36ff3bd52ed7f0d091e2dd9ec7 I would like to quote your article and sincerely hope that you will help me solve this problem. thanks!

ysora commented 1 year ago

It seems like some functions are depreciated now. I promise I will solve it soon. Thanks!

rrdai77 commented 1 year ago

It seems like some functions are depreciated now. I promise I will solve it soon. Thanks!

Hello, I've solved this error, it's my python that's wrong. Thanks!

rrdai77 commented 1 year ago

It seems like some functions are depreciated now. I promise I will solve it soon. Thanks!

Hello, I've solved this error, it's my python that's wrong. Thanks!

ysora commented 1 year ago

Thanks rrdai77, I replaced Pandas's append function to concat function. It is available with Stripenn 1.1.65.16. Thanks.

Sora

ysora commented 1 year ago

I will close this issue.