ysrivast2000 / moodle-qtype_shortanssimilarity

Short Answer Similarity question type plugin for Moodle
GNU General Public License v3.0
0 stars 1 forks source link

curl_init called directly #11

Open danmarsden opened 2 years ago

danmarsden commented 2 years ago

looks like I didn't explain #7 well.

Please don't initate curl_init() directly but use Moodle's own "curl" class which is a wrapper on PHP's curl functions.

there should be a few examples in core code that you can see where this is done.

Many organisations put their moodle site behind a web proxy and the internal curl wrapper takes care of this for you.

tedkrahn commented 2 years ago

@danmarsden Sorry for the delayed response. I have released a new version of this plugin under a different repo (https://github.com/VIP-Research-Group/moodle-qtype_shortanssimilarity). I have changed the plugin to use the filelib.php function download_file_content. I hope this is what you meant.